From 9fda8cadba24259d03c07a847030c3d5bf102b8a Mon Sep 17 00:00:00 2001
From: Knee Cola <kneecola@duck.com>
Date: Mon, 17 Nov 2025 20:51:57 +0100
Subject: [PATCH] Internationalize validation error message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replaced hardcoded "Validation failed" message with translated
version from language files:
- Updated userProfileActions.ts to use t("validation-failed")
- Added translations in English and Croatian
- Reordered general-error div in AccountForm for better layout

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 app/lib/actions/userProfileActions.ts |  2 +-
 app/ui/AccountForm.tsx                | 16 ++++++++--------
 messages/en.json                      |  3 ++-
 messages/hr.json                      |  3 ++-
 4 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/app/lib/actions/userProfileActions.ts b/app/lib/actions/userProfileActions.ts
index 381abbc..6ba6484 100644
--- a/app/lib/actions/userProfileActions.ts
+++ b/app/lib/actions/userProfileActions.ts
@@ -77,7 +77,7 @@ export const updateUserProfile = withUser(async (user: AuthenticatedUser, prevSt
     if (!validatedFields.success) {
         return {
             errors: validatedFields.error.flatten().fieldErrors,
-            message: "Validation failed",
+            message: t("validation-failed"),
             success: false,
         };
     }
diff --git a/app/ui/AccountForm.tsx b/app/ui/AccountForm.tsx
index d6e318a..d86ad0e 100644
--- a/app/ui/AccountForm.tsx
+++ b/app/ui/AccountForm.tsx
@@ -143,14 +143,6 @@ const FormFields: FC<FormFieldsProps> = ({ profile, errors, message }) => {
                 </div>
             </div>
 
-            <div id="general-error" aria-live="polite" aria-atomic="true">
-                {message && (
-                    <p className="mt-2 text-sm text-red-500">
-                        {message}
-                    </p>
-                )}
-            </div>
-
             {hasMissingData && (
                 <div className="alert mt-4 max-w-md flex flex-row items-start">
                     <svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" className="stroke-current shrink-0 w-6 h-6">
@@ -160,6 +152,14 @@ const FormFields: FC<FormFieldsProps> = ({ profile, errors, message }) => {
                 </div>
             )}
 
+            <div id="general-error" aria-live="polite" aria-atomic="true">
+                {message && (
+                    <p className="mt-2 text-sm text-red-500">
+                        {message}
+                    </p>
+                )}
+            </div>
+
             <div className="pt-4">
                 <button className="btn btn-primary w-[5.5em]" disabled={pending}>
                     {pending ? (
diff --git a/messages/en.json b/messages/en.json
index 64cab47..d546790 100644
--- a/messages/en.json
+++ b/messages/en.json
@@ -151,7 +151,8 @@
     "save-button": "Save",
     "cancel-button": "Cancel",
     "validation": {
-      "iban-invalid": "Invalid IBAN format. Please enter a valid IBAN"
+      "iban-invalid": "Invalid IBAN format. Please enter a valid IBAN",
+      "validation-failed": "Validation failed. Please check the form and try again."
     }
   }
 }
\ No newline at end of file
diff --git a/messages/hr.json b/messages/hr.json
index d564788..9538660 100644
--- a/messages/hr.json
+++ b/messages/hr.json
@@ -150,7 +150,8 @@
     "save-button": "Spremi",
     "cancel-button": "Odbaci",
     "validation": {
-      "iban-invalid": "Neispravan IBAN format. Molimo unesite ispravan IBAN."
+      "iban-invalid": "Neispravan IBAN format. Molimo unesite ispravan IBAN.",
+      "validation-failed": "Validacija nije uspjela. Molimo provjerite formu i pokušajte ponovno."
     }
   }
 }
\ No newline at end of file